[DEBT] Rename .h|.hpp|.cuh|.cu|.cpp Files Properly In Our Cuml C++ ...

Skip to content Dismiss alert {{ message }} rapidsai / cuml Public

• Notifications You must be signed in to change notification settings
• Fork 612
• Star 5.1k

• Code
• Issues 839
• Pull requests 49
• Actions
• Projects 2
• Wiki
• Security

  Uh oh!

  There was an error while loading. Please reload this page.

• Insights

Additional navigation options

[DEBT] rename .h|.hpp|.cuh|.cu|.cpp files properly in our cuml C++ source base #1675New issueCopy linkNew issueCopy linkOpenTaskOpen[DEBT] rename .h|.hpp|.cuh|.cu|.cpp files properly in our cuml C++ source base#1675TaskCopy linkAssignees LabelsBuild or DepIssues related to building the code or dependenciesIssues related to building the code or dependenciesCUDA / C++CUDA issueCUDA issueTech DebtIssues related to debtIssues related to debtgood first issueGood for newcomersGood for newcomersproposalChange current process or codeChange current process or code

Description

teju85opened on Feb 13, 2020Issue body actions

Currently, they are just all over the place! I propose the following rule-of-thumb:

1. If a header file contains cuda kernels and/or device methods, then it should be a .cuh.
2. Else, it should be a .hpp (if the current header file is already named as a .h, feel free to leave it as it is, in order to minimize the amount of ripple changes this will cause).
3. If a header file is used to declare our C interface, it should be a .h
4. If the header file includes a .cuh, then it should be a .cuh as well
5. If a source includes a .cuh, then it should be a .cu, else it should be a .cpp
6. All source files defining our C interface should be .c

This will certainly help us in reducing compilation time as well (if we end up cleaning some of the .cu files and renaming them to .cpp).

Metadata

Metadata

Assignees

• divyegala
• prtksh

Labels

Build or DepIssues related to building the code or dependenciesIssues related to building the code or dependenciesCUDA / C++CUDA issueCUDA issueTech DebtIssues related to debtIssues related to debtgood first issueGood for newcomersGood for newcomersproposalChange current process or codeChange current process or code

Type

Task

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

You can’t perform that action at this time.