[DEBT] Rename .h|.hpp|.cuh|.cu|.cpp Files Properly In Our Cuml C++ ...

Trang chủ » .h .hpp » [DEBT] Rename .h|.hpp|.cuh|.cu|.cpp Files Properly In Our Cuml C++ ...

Có thể bạn quan tâm

Skip to content Dismiss alert {{ message }} / cuml Public
  • Notifications You must be signed in to change notification settings
  • Fork 535
  • Star 4.3k
  • Code
  • Issues 859
  • Pull requests 58
  • Actions
  • Projects 2
  • Security
  • Insights
Additional navigation options [DEBT] rename .h|.hpp|.cuh|.cu|.cpp files properly in our cuml C++ source base #1675New issueNew issueOpenOpen[DEBT] rename .h|.hpp|.cuh|.cu|.cpp files properly in our cuml C++ source base#1675

Description

@teju85

teju85openedon Feb 13, 2020

Currently, they are just all over the place! I propose the following rule-of-thumb:

  1. If a header file contains cuda kernels and/or device methods, then it should be a .cuh.
  2. Else, it should be a .hpp (if the current header file is already named as a .h, feel free to leave it as it is, in order to minimize the amount of ripple changes this will cause).
  3. If a header file is used to declare our C interface, it should be a .h
  4. If the header file includes a .cuh, then it should be a .cuh as well
  5. If a source includes a .cuh, then it should be a .cu, else it should be a .cpp
  6. All source files defining our C interface should be .c

This will certainly help us in reducing compilation time as well (if we end up cleaning some of the .cu files and renaming them to .cpp).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Build or DepIssues related to building the code or dependenciesCUDA / C++CUDA issueTech DebtIssues related to debtgood first issueGood for newcomersproposalChange current process or code

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

You can’t perform that action at this time.

Từ khóa » .h .hpp